BetterCorp/BetterFrame
1
0
Fork 0
mirror of https://github.com/BetterCorp/BetterFrame.git synced 2026-05-26 21:26:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix(docker): remove USER directives, let BSB handle privileges

Browse source 
BSB entrypoint at /root/entrypoint.sh runs as root and drops
privileges itself. Our USER node blocked access to entrypoint.
Removed USER root/node, use absolute COPY paths, let BSB own
the user lifecycle.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mitchell R 2026-05-24 02:03:42 +02:00
parent 3a451d88da
commit 4b36812c80
No known key found for this signature in database
1 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
deploy/docker/Dockerfile.server
View file

@ -62,21 +62,17 @@ ARG BF_MQTT_USERNAME=
ARG BF_MQTT_PASSWORD= ARG BF_MQTT_PASSWORD=
ARG BF_MQTT_TOPIC_PREFIX=betterframe ARG BF_MQTT_TOPIC_PREFIX=betterframe
USER root # Install extras (Alpine base) — run as root before BSB drops privileges
# envsubst + ffmpeg (Alpine base)
RUN apk add --no-cache gettext ffmpeg RUN apk add --no-cache gettext ffmpeg
RUN mkdir -p /var/lib/betterframe && chown 1000:1000 /var/lib/betterframe RUN mkdir -p /var/lib/betterframe && chown 1000:1000 /var/lib/betterframe
WORKDIR /home/bsb # Copy built plugin + deps into BSB workdir
COPY --from=builder /app/node_modules /home/bsb/node_modules
# Copy built plugin + deps COPY --from=builder /app/server/lib /home/bsb/lib
COPY --from=builder /app/node_modules ./node_modules COPY --from=builder /app/server/bsb-plugin.json /home/bsb/bsb-plugin.json
COPY --from=builder /app/server/lib ./lib COPY --from=builder /app/server/package.json /home/bsb/package.json
COPY --from=builder /app/server/bsb-plugin.json ./bsb-plugin.json COPY --from=builder /app/tsconfig.base.json /home/bsb/tsconfig.base.json
COPY --from=builder /app/server/package.json ./package.json
COPY --from=builder /app/tsconfig.base.json ./tsconfig.base.json
# Generate sec-config.yaml from template + build args # Generate sec-config.yaml from template + build args
COPY sec-config.template.yaml /tmp/sec-config.template.yaml COPY sec-config.template.yaml /tmp/sec-config.template.yaml
@ -90,5 +86,3 @@ RUN echo "$BF_SERVER_VERSION" > /home/bsb/.bf-version
VOLUME /var/lib/betterframe VOLUME /var/lib/betterframe
EXPOSE 18080 18081 18082 EXPOSE 18080 18081 18082
USER node