BetterCorp/BetterFrame
1
0
Fork 0
mirror of https://github.com/BetterCorp/BetterFrame.git synced 2026-05-26 20:16:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix(db): replace remaining hardcoded 0/1 with boolean params

Browse source 
setup_state.is_complete, cluster_key_provisioned, display.is_primary,
event_log.forwarded_to_nodered all had literal 0/1 in SQL strings.
PG rejects integer for BOOLEAN columns. Changed to ? params with
true/false values — SQLite adapter coerces to 1/0 automatically.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mitchell R 2026-05-24 05:18:43 +02:00
parent 2e88d891e1
commit 41e9991891
No known key found for this signature in database
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
server/src/shared/db/repository.ts
View file

@ -137,10 +137,10 @@ export class Repository {
async markSetupComplete(): Promise<void> { async markSetupComplete(): Promise<void> {
await this._run( await this._run(
`UPDATE setup_state `UPDATE setup_state
SET is_complete = 1, SET is_complete = ?,
completed_at = COALESCE(completed_at, ?) completed_at = COALESCE(completed_at, ?)
WHERE id = 1`, WHERE id = 1`,
[isoNow()], [true, isoNow()],
); );
void this.notify("setup_state", "update", 1); void this.notify("setup_state", "update", 1);
} }
@ -157,7 +157,8 @@ export class Repository {
async markClusterKeyProvisioned(): Promise<void> { async markClusterKeyProvisioned(): Promise<void> {
await this._run( await this._run(
"UPDATE setup_state SET cluster_key_provisioned = 1 WHERE id = 1", "UPDATE setup_state SET cluster_key_provisioned = ? WHERE id = 1",
[true],
); );
} }
@ -380,7 +381,8 @@ export class Repository {
async createDefaultDisplay(): Promise<Display> { async createDefaultDisplay(): Promise<Display> {
const result = await this._run( const result = await this._run(
`INSERT INTO displays (name, "index", is_primary) `INSERT INTO displays (name, "index", is_primary)
VALUES ('primary', 0, 0) RETURNING id`, VALUES ('primary', 0, ?) RETURNING id`,
[false],
); );
const id = Number(result.lastInsertRowid); const id = Number(result.lastInsertRowid);
void this.notify("displays", "create", id); void this.notify("displays", "create", id);
@ -398,10 +400,11 @@ export class Repository {
const idx = input.index ?? await this.nextDisplayIndexForKiosk(kioskId); const idx = input.index ?? await this.nextDisplayIndexForKiosk(kioskId);
const result = await this._run( const result = await this._run(
`INSERT INTO displays (name, "index", is_primary, kiosk_id, width_px, height_px) `INSERT INTO displays (name, "index", is_primary, kiosk_id, width_px, height_px)
VALUES (?, ?, 0, ?, ?, ?) RETURNING id`, VALUES (?, ?, ?, ?, ?, ?) RETURNING id`,
[ [
input.name, input.name,
idx, idx,
false,
kioskId, kioskId,
input.width_px ?? 1920, input.width_px ?? 1920,
input.height_px ?? 1080, input.height_px ?? 1080,
@ -1845,7 +1848,7 @@ export class Repository {
} }
async markEventForwarded(eventId: number): Promise<void> { async markEventForwarded(eventId: number): Promise<void> {
await this._run("UPDATE event_log SET forwarded_to_nodered = 1 WHERE id = ?", [eventId]); await this._run("UPDATE event_log SET forwarded_to_nodered = ? WHERE id = ?", [true, eventId]);
} }
/** /**